Mmdet Fix Image Identifier #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANGAreNotGnu
changed the title
FANGAreNotGnu
changed the title
|
Job PR-2492-7f9f3c2 is done. |
FANGAreNotGnu
changed the title
bryanyzhu
approved these changes
Dec 1, 2022
zhiqiangdon
approved these changes
Dec 8, 2022
gradientsky
reviewed
Dec 8, 2022
Comment on lines
530
to
532
| start_idx = path.rfind("/") + 1 | ||
| end_idx = path.rindex(".") | ||
| return int(path[start_idx:end_idx]) | ||
| return path[start_idx:end_idx] |
There was a problem hiding this comment.
This will not work on Windows since it's using \ as a path separators. I suggest just using pathlib + replace backslashes to linux format:
from pathlib import Path
def get_image_filename(path: str):
return Path(s.replace('\\', '/')).stem
|
Job PR-2492-d406ba0 is done. |
gradientsky
approved these changes
Dec 9, 2022
|
Job PR-2492-8646986 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used the number in image file name as identifier for image path. But the assumption that image name contains a unique number is not valid. Here we changed to use the image file name (without extension) as the identifier.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.