Use detectron2 visualizer and update quickstart #2502
Conversation
…p all annotation xml files
…when labels.txt is not present.
� Conflicts: � multimodal/src/autogluon/multimodal/predictor.py
…s` to using `get_detection_classes`. Refactoring saving results to utils.
� Conflicts: � multimodal/src/autogluon/multimodal/predictor.py
…ing visualization to a separate function call outside predict, removing prints, modifying doc strings, adding TODO to use mmdet visualization later,
…add_detection_inference_quickstart
…add_detection_inference_quickstart
| """ | ||
|
|
||
|
|
||
| class GenericMask: |
There was a problem hiding this comment.
Do you think if we should remove some classes that are currently not used?
There was a problem hiding this comment.
Good catch! I missed this one. Will delete.
There was a problem hiding this comment.
If this one will be deleted, then next function (_PanopticPrediction) also needs to be deleted.
multimodal/src/autogluon/multimodal/utils/object_detection_visualizer.py
Outdated
Show resolved
Hide resolved
| """ | ||
|
|
||
|
|
||
| class GenericMask: |
There was a problem hiding this comment.
If this one will be deleted, then next function (_PanopticPrediction) also needs to be deleted.
multimodal/src/autogluon/multimodal/utils/object_detection_visualizer.py
Show resolved
Hide resolved
…add_detection_inference_quickstart
|
Job PR-2502-008ab54 is done. |
There was a problem hiding this comment.
Left several comments (e.g., two places missing new line). Another thing is, I can't see object detection tutorials on the left panel (http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2502/008ab54/tutorials/multimodal/index.html), and the quick start tutorial is 403 forbidden. Can you fix the comments and also rebase with master? Thank you.
multimodal/src/autogluon/multimodal/utils/object_detection_visualizer.py
Show resolved
Hide resolved
…add_detection_inference_quickstart
|
Job PR-2502-90439c4 is done. |
|
Job PR-2502-0b7d865 is done. |
|
Job PR-2502-be9a2c9 is done. |
Issue #, if available:
Description of changes: Use detectron2 visualizer and update quickstart
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.