Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for preprocessing mutation #2540

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add tests for preprocessing mutation #2540

merged 1 commit into from
Dec 8, 2022

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Dec 8, 2022

Issue #, if available:

Description of changes:

  • Add tests for preprocessing mutation
  • This improves our certainty that a feature generator is not performing in-place operations on the data that alter the outer context of the input.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

liangfu
liangfu approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution.

@Innixma Innixma merged commit 0a62d48 into master Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Job PR-2540-96eae82 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2540/96eae82/index.html

@Innixma Innixma deleted the add_extra_mutation_checks branch January 18, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangfu liangfu liangfu approved these changes

@gradientsky gradientsky Awaiting requested review from gradientsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Innixma @liangfu