[Bug] Fix missing Predictor API docs on Website #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this PR passes CI and is approved, we need to also merge the same changes into |
|
Job PR-2573-a78915e is done. |
shchur
approved these changes
Dec 14, 2022
|
Verified the Predictor API docs are back on CI built version: http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2573/a78915e/api/autogluon.predictor.html |
Innixma
approved these changes
Dec 14, 2022
| } | ||
|
|
||
| function install_multimodal { | ||
| # launch different process for each test to make sure memory is released | ||
| python3 -m pip install --upgrade pytest-xdist | ||
| python3 -m pip install --upgrade -e multimodal/[tests] | ||
| install_local_packages "multimodal/$1" |
There was a problem hiding this comment.
outside of the scope of this PR, but its a bit concerning we are doing special pip installs afterwards in our tests for multimodal... This isn't replicating the user experience. Especially using uncapped versions in the install.
yinweisu
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2571
Description of changes:
The
install_allbash call inbuild_all_docswas removed in this commit because of a package dependency conflict betweentoxfor testing inedamodule and dependencies of thed2lbooktool.Unfortunately
install_allcall was required to install modules that are used during autogen of docs, resulting in the website API documentation problem described in the issue.The fix here is to create a new
install_all_no_testscall that avoids installing tests including thetoxdependency wheneda/[tests]is installed. In order to do this, I cleaned up the bash scripts we use to install packages so that it is less pedantic and less code is repeated.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.