Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tabular Ensemble Folding #2582

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Fix Tabular Ensemble Folding #2582

merged 3 commits into from
Dec 19, 2022

Conversation

yinweisu
Copy link
Collaborator

@yinweisu yinweisu commented Dec 19, 2022

Issue #, if available:
#2581

Description of changes:

  • model_base is not available when doing repeated bagging. Use _get_child_aux_val to retrieve params instead.
  • Added check of if is_initialized() check in BaggedEnsembleModel._get_child_aux_val(). @Innixma Let me know if it's missing intentionally.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

Job PR-2582-22fe167 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2582/22fe167/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for finding and fixing the issue!

@yinweisu yinweisu merged commit 225ff77 into autogluon:master Dec 19, 2022
@yinweisu yinweisu deleted the weisu_fix branch December 19, 2022 23:21
@github-actions
Copy link

Job PR-2582-a717023 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2582/a717023/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants