-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[timeseries] Speed up the train/val splitter #2586
Conversation
097d2a0
to
77c7f57
Compare
Job PR-2586-77c7f57 is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some questions.
Job PR-2586-12d2b30 is done. |
12d2b30
to
7d41cb1
Compare
Job PR-2586-7d41cb1 is done. |
Description of changes:
append_suffix_to_item_id
functionDataFrame.loc[index]
operation withDataFrame.query("item_id in @index")
.Testing on a subset of 5000 items from the M5 competition dataset:
Using code currently on
master
:After current PR:
Code for reproducing the results
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.