-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[timeseries] Speed up TimeSeriesEnsembleSelection.fit #2602
Conversation
702e066
to
396af8f
Compare
TimeSeriesEnsembleSelection.fit
Job PR-2602-702e066 is done. |
Job PR-2602-396af8f is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Some comments regarding naming and style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Job PR-2602-3aff1c9 is done. |
Description of changes:
TimeSeriesDataFrame.slice_by_timestep
operation when computing the metrics while fitting an ensemble.Runtime comparison of
fit_ensemble()
with 2 base modelsM4-hourly (350K rows, 414 items)
master
branchM4-daily (10M rows, 4227 items)
master
branchBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.