Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] Speed up TimeSeriesEnsembleSelection.fit #2602

Merged
merged 5 commits into from
Dec 24, 2022

Conversation

shchur
Copy link
Collaborator

@shchur shchur commented Dec 23, 2022

Description of changes:

  • Avoid the costly TimeSeriesDataFrame.slice_by_timestep operation when computing the metrics while fitting an ensemble.

Runtime comparison of fit_ensemble() with 2 base models

M4-hourly (350K rows, 414 items)

  • Current master branch
Fitting simple weighted ensemble.
        33.31   s     = Training runtime
  • This PR
Fitting simple weighted ensemble.
        4.59    s     = Training runtime

M4-daily (10M rows, 4227 items)

  • Current master branch
Fitting simple weighted ensemble.
        1120.93 s     = Training runtime
  • This PR
Fitting simple weighted ensemble.
        18.20   s     = Training runtime

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shchur shchur added this to the 0.6.2 Release milestone Dec 23, 2022
@shchur shchur added the module: timeseries related to the timeseries module label Dec 23, 2022
@shchur shchur changed the title [timeseries] Speed up TimeSeriesEnsembleSelection.fit [timeseries] Speed up TimeSeriesEnsembleSelection.fit Dec 23, 2022
@github-actions
Copy link

Job PR-2602-702e066 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2602/702e066/index.html

@github-actions
Copy link

Job PR-2602-396af8f is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2602/396af8f/index.html

Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some comments regarding naming and style.

timeseries/src/autogluon/timeseries/evaluator.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/evaluator.py Outdated Show resolved Hide resolved
Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Job PR-2602-3aff1c9 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2602/3aff1c9/index.html

@shchur shchur merged commit 0e12d9f into autogluon:master Dec 24, 2022
@shchur shchur deleted the ensemble-speedup branch December 24, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: timeseries related to the timeseries module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants