Suppport realtime inference for matcher #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-2613-f7516c6 is done. |
zhiqiangdon
requested review from
sxjscience,
bryanyzhu,
cheungdaven,
suzhoum,
FANGAreNotGnu and
yongxinw
cheungdaven
reviewed
Jan 3, 2023
| prob = F.softmax(logits.float(), dim=1)[:, 1] | ||
| else: | ||
| cosine_similarity = F.cosine_similarity(embeddings1, embeddings2) | ||
| prob = 0.5 * (cosine_similarity + 1) |
There was a problem hiding this comment.
Is it necessary to convert similarity into probability in this way? I guess users care more about the real matching similarity in most cases.
There was a problem hiding this comment.
This function is to compute the probability, normalized to range (0, 1), which is required in computing some validation metrics, e.g., roc_auc. To compute the cosine similarity, users can call another util function compute_semantic_similarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
predict(),realtime_predict(), andprocess_batch()util functions to support both predictor and matcher._predict(),_realtime_predict(), and_process_batchfrompredictor.py.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.