Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support presets in AutoMM predictor initialization #2620

Merged
merged 6 commits into from
Jan 3, 2023

Conversation

zhiqiangdon
Copy link
Contributor

@zhiqiangdon zhiqiangdon commented Jan 2, 2023

Issue #, if available:

Description of changes:

  1. Let users use presets in predictor initialization. The presets is to control model quality: best_quality, high_quality_fast_inference, and medium_quality_faster_inference.
  2. Fix ner presets. Use the registered ner presets rather than the default.
  3. Add unit tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Job PR-2620-e988188 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2620/e988188/index.html

"model.ner_text.checkpoint_name": "microsoft/deberta-v3-base",
}


@automm_presets.register()
def ner():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we call it default_ner?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, all specific problem types, e.g., image_text_similarity and object_detection, have registered presets. default is for the general problem types binary, multiclass, and regression.

@sxjscience
Copy link
Collaborator

LGTM in general. Minor comment on the naming.

We can consider to register default_{problem_type} for all the problem types, rather than using {problem_type}.

Copy link
Contributor

@bryanyzhu bryanyzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One side question, where should we introduce these presets to users, in the apis documentation or automm customization tutorial page?

Copy link
Collaborator

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can add an additional tutorial to introduce presets

@sxjscience sxjscience merged commit 3e0f876 into autogluon:master Jan 3, 2023
@zhiqiangdon zhiqiangdon deleted the mm-presets branch January 5, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants