Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dask and distributed dependencies #2691

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Remove dask and distributed dependencies #2691

merged 3 commits into from
Feb 2, 2023

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Jan 13, 2023

Issue #, if available:

Description of changes:

  • Remove dask and distributed dependencies
  • This is to check if they are actually needed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 0.7 Release milestone Jan 14, 2023
@@ -55,6 +55,7 @@
"openmim>0.1.5,<=0.2.1",
"defusedxml>=0.7.1,<=0.7.1",
"albumentations>=1.1.0,<=1.2.0",
"jinja2>=3.0.3,<3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we use jinja2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer to the CI error prior to me adding it in this PR: https://github.com/autogluon/autogluon/actions/runs/3914783191/jobs/6692268378#step:4:994

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for supporting prompt source. I’m okay with removing it for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sxjscience if you'd like to remove jinja usage, you'll need to open a separate follow-up PR. I believe jinja was a dependency of dask/distributed, which is why we didn't error in the past, but with dask/distributed removed, now we need to explicitly add it as a dependency to AutoMM

@Innixma Innixma force-pushed the try_remove_dask branch 2 times, most recently from 047924e to 4824165 Compare January 19, 2023 23:27
@Innixma Innixma added the priority: 0 Maximum priority label Feb 1, 2023
@Innixma Innixma added the dependency Related to dependency packages label Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Job PR-2691-63ac256 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2691/63ac256/index.html

Copy link
Collaborator

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Innixma Innixma merged commit 61cc84e into master Feb 2, 2023
@Innixma Innixma deleted the try_remove_dask branch November 30, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Related to dependency packages priority: 0 Maximum priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants