-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dask and distributed dependencies #2691
Conversation
multimodal/setup.py
Outdated
@@ -55,6 +55,7 @@ | |||
"openmim>0.1.5,<=0.2.1", | |||
"defusedxml>=0.7.1,<=0.7.1", | |||
"albumentations>=1.1.0,<=1.2.0", | |||
"jinja2>=3.0.3,<3.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we use jinja2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can refer to the CI error prior to me adding it in this PR: https://github.com/autogluon/autogluon/actions/runs/3914783191/jobs/6692268378#step:4:994
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for supporting prompt source. I’m okay with removing it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sxjscience if you'd like to remove jinja usage, you'll need to open a separate follow-up PR. I believe jinja was a dependency of dask/distributed, which is why we didn't error in the past, but with dask/distributed removed, now we need to explicitly add it as a dependency to AutoMM
047924e
to
4824165
Compare
4824165
to
b63d6f9
Compare
Job PR-2691-63ac256 is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.