Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabular: Fix edge-case text preprocessing bug #2705

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Tabular: Fix edge-case text preprocessing bug #2705

merged 1 commit into from
Jan 17, 2023

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Jan 16, 2023

Issue #, if available:
resolves #2688

Description of changes:

  • Previously the change added in [Tabular] Avoid copying identical dataframes #2532 created a subtle bug when only text features were present in the data due to the inplace renaming operation for raw text.
  • Because we didn't test for this specific scenario where only text features are provided, we did not catch this issue.
  • This fixes the bug by setting inplace=False during feature renaming
  • Also adds a unit test to check that the bug is fixed.
  • v0.6.2 workaround: Avoid only passing text features to TabularPredictor, instead include the text features with other features or create dummy features to pass alongside the text features.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

Job PR-2705-d150e3e is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2705/d150e3e/index.html

@Innixma Innixma merged commit 1db8dd8 into master Jan 17, 2023
@Innixma Innixma deleted the fix_2688 branch January 18, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants