Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower-bound Pillow #2708

Closed
wants to merge 1 commit into from
Closed

Conversation

sxjscience
Copy link
Collaborator

Issue #, if available:

#2707

Description of changes:
The PIL.Image.Resampling was added in Pillow 9.1.0. So added the lower-bound. Reference: https://stackoverflow.com/questions/71738218/module-pil-has-not-attribute-resampling

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should figure out why it crashes instead of downgrading the version range.

@@ -24,7 +24,7 @@
"scipy",
"pandas",
"scikit-learn",
"Pillow",
"Pillow>=9.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will simply override the _setup_utils range: https://github.com/autogluon/autogluon/blob/master/core/src/autogluon/core/_setup_utils.py#L27

We should have a consistent range. I believe lower bound 9.3.0 was set due to a security issue with earlier versions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, there is no bug then. The Colab issue can be resolved by restarting the runtime.

@sxjscience sxjscience closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants