Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tabular] mention persist and compile in deploy tutorial #2717

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

liangfu
Copy link
Collaborator

@liangfu liangfu commented Jan 17, 2023

Issue #, if available:

Description of changes:

This PR updates the tabular model deployment tutorial with some context on persist_models and compile_models for efficient real-time prediction.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

Job PR-2717-a175686 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2717/a175686/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, looks good overall!

docs/tutorials/tabular_prediction/tabular-deployment.md Outdated Show resolved Hide resolved
docs/tutorials/tabular_prediction/tabular-deployment.md Outdated Show resolved Hide resolved
Comment on lines 150 to 152
```{.python .input}
predictor_clone_opt.compile_models()
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably cause the tutorial to return False in the later check that the predictions are equivalent. Instead, have the equivalency checks prior to the compile_models step, then predict again and mention that predictions might not be exactly the same, but should be very close.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to bottom part of the tutorial and mentioned the potential difference.

@Innixma Innixma added this to the 0.7 Release milestone Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Job PR-2717-0298008 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2717/0298008/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Had 1 comment

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Job PR-2717-64c6a22 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2717/64c6a22/index.html

@liangfu liangfu merged commit 4fff472 into autogluon:master Feb 7, 2023
@liangfu liangfu deleted the tutorial-1 branch February 7, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants