-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multimodal] Merge dump for hf and timm #2737
[multimodal] Merge dump for hf and timm #2737
Conversation
Job PR-2737-70c8c01 is done. |
Job PR-2737-a0692f6 is done. |
multimodal/tests/unittests/predictor/test_predictor_model_dump.py
Outdated
Show resolved
Hide resolved
multimodal/tests/unittests/predictor/test_predictor_model_dump.py
Outdated
Show resolved
Hide resolved
Job PR-2737-c81cbbd is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Job PR-2737-eb7d609 is done. |
Job PR-2737-1da17d4 is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the awesome refactor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@FANGAreNotGnu Feel free to merge it. |
Merge the dump function for huggingface_text and timm_image. It will also work for mmdet_image by adding a few lines after the other PR is merged.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.