Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multimodal] Merge dump for hf and timm #2737

Merged

Conversation

FANGAreNotGnu
Copy link
Contributor

@FANGAreNotGnu FANGAreNotGnu commented Jan 20, 2023

Merge the dump function for huggingface_text and timm_image. It will also work for mmdet_image by adding a few lines after the other PR is merged.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@FANGAreNotGnu FANGAreNotGnu changed the title [wip] merge dump for hf and timm [WIP] merge dump for hf and timm Jan 20, 2023
@github-actions
Copy link

Job PR-2737-70c8c01 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2737/70c8c01/index.html

@github-actions
Copy link

Job PR-2737-a0692f6 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2737/a0692f6/index.html

@FANGAreNotGnu FANGAreNotGnu changed the title [WIP] merge dump for hf and timm merge dump for hf and timm Jan 21, 2023
@FANGAreNotGnu FANGAreNotGnu changed the title merge dump for hf and timm [multimodal] Merge dump for hf and timm Jan 21, 2023
@github-actions
Copy link

Job PR-2737-c81cbbd is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2737/c81cbbd/index.html

Copy link
Contributor

@zhiqiangdon zhiqiangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Job PR-2737-eb7d609 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2737/eb7d609/index.html

@github-actions
Copy link

Job PR-2737-1da17d4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2737/1da17d4/index.html

Copy link
Contributor

@suzhoum suzhoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome refactor!

Copy link
Collaborator

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sxjscience
Copy link
Collaborator

@FANGAreNotGnu Feel free to merge it.

@sxjscience sxjscience merged commit 20a6981 into autogluon:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants