Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ag.vision in AG v0.7 #2790

Merged
merged 7 commits into from
Feb 2, 2023
Merged

Conversation

bryanyzhu
Copy link
Contributor

@bryanyzhu bryanyzhu commented Jan 31, 2023

Issue #, if available:
#2694 #2695

Description of changes:
Deprecate ag.vision in AG v0.7

  • modify readme
  • modify index page
  • modify tutorial page
  • Also remove tutorials, modify index page for ag.text

Will test backward compatibility once HPO preset PR is merged.
Will open another PR to remove ag.vision from CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

Job PR-2790-2666dd1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2790/2666dd1/index.html

@bryanyzhu bryanyzhu changed the title Deprecate ag.vision in AG v0.7 [WIP] Deprecate ag.vision in AG v0.7 Jan 31, 2023
@bryanyzhu bryanyzhu changed the title [WIP] Deprecate ag.vision in AG v0.7 Deprecate ag.vision in AG v0.7 Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Job PR-2790-9eaf25c is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2790/9eaf25c/index.html

Copy link
Collaborator

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@FANGAreNotGnu FANGAreNotGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@zhiqiangdon zhiqiangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinweisu
Copy link
Collaborator

yinweisu commented Feb 2, 2023

Do we want to remove the vision source code too?

@bryanyzhu
Copy link
Contributor Author

Do we want to remove the vision source code too?

At this moment, I see the source code for ag.text also exists. If we agree to remove the entire folder, we can do this in another PR.

@Innixma
Copy link
Contributor

Innixma commented Feb 2, 2023

Yes we should remove the source code for text and vision, but that should be a separate PR.

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Job PR-2790-402ca2a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2790/402ca2a/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants