Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] Add ujson dependency to silence the GluonTS warning #2816

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

shchur
Copy link
Collaborator

@shchur shchur commented Feb 2, 2023

Description of changes:

  • The new GluonTS version seems to overcome our method for silencing the JSON warning, so it's probably easier to just add ujson as a dependency. The library is actively developed and actually isn't use in our code, so it should be safe.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Job PR-2816-bc0562d is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2816/bc0562d/index.html

@shchur shchur merged commit dc21d0b into autogluon:master Feb 2, 2023
@shchur shchur deleted the silence-json branch February 2, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants