Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gluoncv #2832

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Remove gluoncv #2832

merged 5 commits into from
Feb 7, 2023

Conversation

bryanyzhu
Copy link
Contributor

Issue #, if available:
#2694

Description of changes:
Remove remaining existence of autogluon.vision, ImagePredictor, ObjectDetector and gluoncv

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Innixma
Innixma approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bryanyzhu
Copy link
Contributor Author

LGTM!

Thanks for approving. @Innixma I did several searches through the codebase, didn't find more existence of
autogluon.vision, ImagePredictor, ObjectDetector and gluoncv. Please let me know if you know other places using vision or any code needs to be double checked. Thank you.

@Innixma
Copy link
Contributor

Innixma commented Feb 3, 2023

@bryanyzhu I think we should be good. Our CI would error if anything major was still present. We can do a final sanity check of our docs during hard code-freeze.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Job PR-2832-9502d7b is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2832/9502d7b/index.html

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Job PR-2832-8b12b32 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2832/8b12b32/index.html

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Job PR-2832-f1f97a9 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2832/f1f97a9/index.html

@bryanyzhu bryanyzhu merged commit 6f700e6 into autogluon:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Innixma Innixma Innixma approved these changes

@yinweisu yinweisu yinweisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryanyzhu @Innixma @yinweisu