Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocClassifier] add missing documents support and exception handling #2833

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

cheungdaven
Copy link
Contributor

@cheungdaven cheungdaven commented Feb 3, 2023

Description of changes:

  • Support missing documents.
  • exception handling for opening images.
  • change top_k_average_method to best in the tutorial.
  • remove dependence on lightning cloud_io.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cheungdaven cheungdaven added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Job PR-2833-4ec046a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2833/4ec046a/index.html

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Job PR-2833-ab6321d is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2833/ab6321d/index.html

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Job PR-2833-109b189 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2833/109b189/index.html

# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Utilities related to data saving/loading."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need cloudio?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there before. I removed it because of the log: /home/ci/opt/venv/lib/python3.8/site-packages/pytorch_lightning/utilities/cloud_io.py:33: LightningDeprecationWarning: pytorch_lightning.utilities.cloud_io.get_filesystem has been deprecated in v1.8.0 and will be removed in v1.10.0. Please use lightning_lite.utilities.cloud_io.get_filesystem instead.
rank_zero_deprecation(
/home/ci/opt/venv/lib/python3.8/site-packages/pytorch_lightning/utilities/cloud_io.py:25: LightningDeprecationWarning: pytorch_lightning.utilities.cloud_io.atomic_save has been deprecated in v1.8.0 and will be removed in v1.10.0. This function is internal but you can copy over its implementation.
rank_zero_deprecation(

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Job PR-2833-169c234 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2833/169c234/index.html

Copy link
Contributor

@zhiqiangdon zhiqiangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cheungdaven cheungdaven merged commit c7a4cb1 into autogluon:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants