[multimodal] Unifying dump/export model by introducing ExportMixin #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangfu
added
the
model list checked
|
Job PR-2840-d9d22dd is done. |
|
Job PR-2840-bc30e43 is done. |
| from .onnx import get_onnx_input | ||
|
|
||
|
|
||
| class ExportMixin: |
There was a problem hiding this comment.
Will this Mixin also supports matcher?
There was a problem hiding this comment.
I'm not quite sure whether it would support matcher. It should behavior exactly as before. This is no implementation change. Just moved dump_model and export_onnx out of the MultiModalPredictor.
suzhoum
approved these changes
Feb 7, 2023
|
Job PR-2840-a6df52b is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
multimodal/tests/unittests/others/{test_deployment.py => test_deployment_onnx.py}
multimodal/tests/unittests/{others_2/test_predictor_model_dump.py => others/test_deployment_torch.py}
This would help reduce the size of the predictor.py file.
The dump_model and export_onnx related functions are moved to the ExportMixin class
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.