-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise the logging functionality and add log about tensorboard #2859
Revise the logging functionality and add log about tensorboard #2859
Conversation
Job PR-2859-23a6d96 is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for improving the logging functionality.
Job PR-2859-9da3486 is done. |
Job PR-2859-2d3404f is done. |
Job PR-2859-c6a1815 is done. |
Job PR-2859-704fc28 is done. |
logger.info(f"Models and intermediate outputs are saved to {self._save_path} ") | ||
|
||
# TODO(?) We should have a separate "_post_training_event()" for logging messages. | ||
logger.info(get_fit_complete_message(self._save_path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is info
shown by default or only if the user increases verbosity? In what situation will the user see the new logs added in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's shown by default (verbosity=2,3).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Innixma Our logger seems to have a bug. Setting verbosity=4 doesn't print the messages in logger.debug()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhiqiangdon Can you create a GitHub issue with a minimal reproducible example with the logger in isolation?
Job PR-2859-1ea20ad is done. |
Job PR-2859-afbb31e is done. |
Job PR-2859-a1a29e9 is done. |
Job PR-2859-f983589 is done. |
Job PR-2859-c710935 is done. |
Job PR-2859-28ef00d is done. |
Job PR-2859-4b680d6 is done. |
Job PR-2859-62f34e9 is done. |
Job PR-2859-5308445 is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can probably do any remaining cleanup of logging during code freeze for minor changes
Job PR-2859-f1821db is done. |
Job PR-2859-c93ad31 is done. |
Issue #, if available:
#2049
Description of changes:
When the training just started:
When the training completed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.