Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Post 0.7] [DocClassifier] PDF Document Classification #2864

Merged
merged 40 commits into from
Mar 6, 2023
Merged

[Post 0.7] [DocClassifier] PDF Document Classification #2864

merged 40 commits into from
Mar 6, 2023

Conversation

cheungdaven
Copy link
Contributor

@cheungdaven cheungdaven commented Feb 8, 2023 •
edited

Issue #, if available:

Description of changes:

  1. support pdf document classification [single page].
  2. Add tutorial for pdf document classification.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cheungdaven cheungdaven added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Feb 8, 2023
@cheungdaven cheungdaven changed the title [WIP] PDF Document Classification [WIP] [post 0.7] PDF Document Classification Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Job PR-2864-42a4d00 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/42a4d00/index.html

@cheungdaven cheungdaven changed the title [WIP] [post 0.7] PDF Document Classification [DocClassifier] [post 0.7] PDF Document Classification Feb 10, 2023
@github-actions
Copy link

Job PR-2864-7fd93ba is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/7fd93ba/index.html

@github-actions
Copy link

Job PR-2864-1293466 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/1293466/index.html

@github-actions
Copy link

Job PR-2864-9a70202 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/9a70202/index.html

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Job PR-2864-7e26418 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/7e26418/index.html

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Job PR-2864-dc9d81a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/dc9d81a/index.html

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Job PR-2864-d84ad97 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/d84ad97/index.html

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Job PR-2864-8968a8a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/8968a8a/index.html

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Job PR-2864-98ba24a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/98ba24a/index.html

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Job PR-2864-8287e89 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/8287e89/index.html

Harry-zzh
Harry-zzh reviewed Mar 4, 2023
View reviewed changes
multimodal/src/autogluon/multimodal/data/infer_types.py
for per_doc in docs:
# If there is non-pdf document, return False
if not per_doc.endswith(".pdf"):
return False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about a question. Do we have some logics to handle the situation in which a non-PDF document is encountered? Are there any warnings return to the users?

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Job PR-2864-77eb107 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2864/77eb107/index.html

@cheungdaven cheungdaven merged commit d071463 into autogluon:master Mar 6, 2023
@cheungdaven cheungdaven deleted the doc_class branch March 15, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harry-zzh Harry-zzh Harry-zzh left review comments

@zhiqiangdon zhiqiangdon zhiqiangdon approved these changes

@sxjscience sxjscience Awaiting requested review from sxjscience

@FANGAreNotGnu FANGAreNotGnu Awaiting requested review from FANGAreNotGnu

@suzhoum suzhoum Awaiting requested review from suzhoum

@tonyhoo tonyhoo Awaiting requested review from tonyhoo

@yongxinw yongxinw Awaiting requested review from yongxinw

Assignees
No one assigned
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheungdaven @zhiqiangdon @Harry-zzh