Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabular: Switch to use multimodal fusion #2890

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Feb 10, 2023

Issue #, if available:

Description of changes:

  • Switch Tabular's 'multimodal' hyperparameter preset to use 1 AutoMM model rather than 2 models (one for text+tabular and one for vision).
  • This leverages the benefits of AutoMM's multimodal fusion accuracy enhancements when text, tabular, and images are present in a single dataset.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -3,7 +3,6 @@

@pytest.mark.gpu
def test_automm_sts(fit_helper):
pytest.skip("Temporary skip the unittest")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we skip it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We skipped this test previously because AutoMM was unstable in unit tests and we weren't actually using AutoMM in any Tabular config. It is no longer unstable and now with this switch we are directly using AutoMM in the multimodal tabular config, so we should enable the test. (Technically it should be have been enabled earlier, but wasn't)

@github-actions
Copy link

Job PR-2890-5b06366 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2890/5b06366/index.html

@Innixma Innixma merged commit e6458bd into autogluon:master Feb 10, 2023
@Innixma Innixma deleted the tabular_use_automm_full branch February 11, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants