Add lower bounds to Multimodal dependencies #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxjscience
reviewed
Feb 13, 2023
sxjscience
reviewed
Feb 13, 2023
|
Commented on two lower-bounds. I think we can use “>=xxxx” for the lower-bounds. |
|
I have updated the two lower bounds as suggested:
|
|
@sxjscience The |
tonyhoo
approved these changes
Feb 13, 2023
|
@giswqs can you rebase? Should fix unit tests |
sxjscience
approved these changes
Feb 14, 2023
|
Job PR-2906-676bffd is done. |
|
All checks have passed! |
|
Thanks @giswqs ! The PR has been merged! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lower bounds to multimodal dependencies, addressing issue #2901
@sxjscience
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.