Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #2907

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Fix typos #2907

merged 4 commits into from
Feb 14, 2023

Conversation

giswqs
Copy link
Contributor

@giswqs giswqs commented Feb 13, 2023

This PR fixes many typoes detected by codespell.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tonyhoo
tonyhoo approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@tonyhoo tonyhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. LGTM! Any chance we can add it to our lint or github check using the pre-commit hooks

@tonyhoo tonyhoo added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Feb 13, 2023
@tonyhoo tonyhoo added this to the 0.7 Release milestone Feb 13, 2023
@giswqs
Copy link
Contributor Author

giswqs commented Feb 13, 2023

Yes, I can submit another PR to add spell check to GitHub Actions once this one is merged.

@github-actions
Copy link

Job PR-2907-d9fdc06 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2907/d9fdc06/index.html

@giswqs
Copy link
Contributor Author

giswqs commented Feb 14, 2023

All checks have passed.

Innixma
Innixma reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I've noticed some fixes that may be incorrect, comments below.

examples/automm/kaggle_feedback_prize/README.md Outdated Show resolved Hide resolved
examples/automm/kaggle_feedback_prize/README.md Outdated Show resolved Hide resolved
Innixma
Innixma requested changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to comments by Xingjian, we can remove the changes on the real-text data

@github-actions
Copy link

Job PR-2907-8735cc4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2907/8735cc4/index.html

@github-actions
Copy link

Job PR-2907-dd0adc6 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2907/dd0adc6/index.html

Innixma
Innixma approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks for the typo fixes!

@Innixma Innixma merged commit be4641d into autogluon:master Feb 14, 2023
@Innixma Innixma added API & Doc Improvements or additions to documentation and removed model list checked You have updated the model list after modifying multimodal unit tests/docs labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxjscience sxjscience sxjscience left review comments

@tonyhoo tonyhoo tonyhoo approved these changes

@Innixma Innixma Innixma approved these changes

Assignees
No one assigned
Labels
API & Doc Improvements or additions to documentation
Projects
None yet
Milestone
0.7 Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giswqs @tonyhoo @sxjscience @Innixma