Allow no y in leaderboard #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Innixma
added
enhancement
tonyhoo
approved these changes
Feb 14, 2023
| @@ -74,15 +71,3 @@ def list_bucket_prefix_suffix_contains_s3(bucket, prefix, suffix=None, banned_su | |||
| files.append(object_summary.key) | |||
|
|
|||
| return files | |||
|
|
|||
|
|
|||
| def load_multipart_s3(bucket, prefix, columns_to_keep=None, dtype=None, sample_count=None): | |||
There was a problem hiding this comment.
Thanks for cleaning this up
|
Job PR-2912-ca0797a is done. |
|
Job PR-2912-a9f9120 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2820 (Part of the process to make the benchmark throughput easy for users to do on their own datasets)
Description of changes:
predictor.leaderboard(data)call, this PR allowsdatato not have the label column, since it isn't required (no scoring being done). This enables easier usage of inference speed analysis code that doesn't unnecessarily require the label column.load_s3.py, the same code but updated already exists inload_pd.py. Removing this code eliminates a circular import that causes ray to error in certain situations (Note: Error situation is outside of normal usage and did not effect users, only occurred when trying to parallelize boto3 calls using ray).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.