Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AutoGluon Webpage #2924

Merged
merged 168 commits into from
Mar 6, 2023
Merged

New AutoGluon Webpage #2924

merged 168 commits into from
Mar 6, 2023

Conversation

gidler
Copy link
Collaborator

@gidler gidler commented Feb 15, 2023

Description of changes:

This change is a major facelift on the AutoGluon webpage. It allows AutoGluon to leave behind the outdated version of d2l-book that the webpage was tied to, along with limitations on the version of Sphinx that could be used. We now use the sphinx furo theme, but can be more easily changed in the future by choosing other sphinx-design themes.

This change touches most files in the docs directory. I intend to split the review of this PR across:

  • changes in .github directory
  • changes to website config and build process
  • changes in tutorials directory which can be inspected by different vertical teams

Tutorials are now maintained in ipynb notebooks rather than md files. This change come with significant pros and cons:
Pros:

  • easy for users to download and use AutoGluon tutorials directly from repository
  • easy to maintain notebooks that can be opened in Colab or Studio lab

Cons:

  • authoring and reviewing ipynb files is more difficult (using this tool can help mitigate this)

When reviewing these changes, it is probably easier to inspect tutorials on the new webpage than it will be to look through raw files and diffs.

This PR is to merge the new website onto master/dev. Once we are comfortable with it, we will merge onto stable as well.

This checklist of items needs to be done before merge:

  • AutoGluon 0.7 Release
  • Remove new branch url from Colab/Studio Lab links
  • Update 0.6.2 to 0.7.0 in new docs
  • Add/remove pre- from correct locations in Install page

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gidler gidler added model list checked You have updated the model list after modifying multimodal unit tests/docs API & Doc Improvements or additions to documentation labels Feb 15, 2023
@github-actions
Copy link

Job PR-2924-7d38808 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/7d38808/index.html

@github-actions
Copy link

Job PR-2924-dce8df7 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/dce8df7/index.html

@github-actions
Copy link

Job PR-2924-c0fc7f8 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/c0fc7f8/index.html

@github-actions
Copy link

Job PR-2924-2e2e60a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/2e2e60a/index.html

@github-actions
Copy link

Job PR-2924-a5fb2a6 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/a5fb2a6/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Added comments.

In general, Tabular LGTM!

docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated
Modules and optional dependencies:

1. `autogluon.tabular`: functionality for tabular data (TabularPredictor)
- Optional dependencies included by default: `lightgbm`,`catboost`,`xgboost`,`fastai`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are part of the optional dependency all, which is included by default during pip install autogluon.

Calling pip install autogluon.tabular will not install these dependencies. The user will need to specify pip install autogluon.tabular[all].

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the modularized install instructions on my most recent push.

docs/install.md Outdated

1. `autogluon.tabular`: functionality for tabular data (TabularPredictor)
- Optional dependencies included by default: `lightgbm`,`catboost`,`xgboost`,`fastai`.
- Optional dependencies not included by default: `vowpalwabbit`, `skex`. The later will speedup KNN training and inference on CPU by 25x.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later -> latter

Missing mention of optional dependencies imodels and skl2onnx

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the modularized install instructions on my most recent push.

docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/tutorials/tabular/tabular-quick-start.ipynb Outdated Show resolved Hide resolved
@@ -0,0 +1,345 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This quick start is pretty good. We may want to consider using titanic instead of this example (although we definitely should keep this example for at least 1 tutorial, since it is quite good). For the purposes of an initial merge, I am ok with this tutorial.

The main thing we should add to this tutorial is a comparison of how simple this solution is + how strong the result is compared to DeepMind's original solution that was on the cover of nature (300+ lines of code & 80% accuracy with DeepMind vs 3 lines of code & 95% accuracy with AutoGluon). This comparison shouldn't be present in a quick-start tutorial, which is why we should wait to add that comparison until we make a different quick-start tutorial for Tabular.

docs/api/autogluon.tabular.rst Outdated Show resolved Hide resolved
@github-actions
Copy link

Job PR-2924-3a58579 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/3a58579/index.html

@Innixma Innixma added the priority: 0 Maximum priority label Feb 21, 2023
@Innixma Innixma added this to the 0.7 Fast-Follow Items milestone Feb 21, 2023
@github-actions
Copy link

Job PR-2924-185d50f is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/185d50f/index.html

@github-actions
Copy link

Job PR-2924-1fe92ce is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/1fe92ce/index.html

@github-actions
Copy link

Job PR-2924-9226be5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/9226be5/index.html

@github-actions
Copy link

Job PR-2924-8cf5222 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/8cf5222/index.html

@github-actions
Copy link

Job PR-2924-f5541d5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/f5541d5/index.html

@github-actions
Copy link

Job PR-2924-4761f3d is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/4761f3d/index.html

@github-actions
Copy link

Job PR-2924-024484c is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/024484c/index.html

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Job PR-2924-29f5bc5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/29f5bc5/index.html

Copy link
Collaborator

@yinweisu yinweisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general regarding the workflow change. Had one minor comment

Comment on lines -62 to -64
sed -i -e "s@###_PLACEHOLDER_WEB_CONTENT_ROOT_###@http://$site@g" docs/config.ini
sed -i -e "s@###_OTHER_VERSIONS_DOCUMENTATION_LABEL_###@$other_doc_version_text@g" docs/config.ini
sed -i -e "s@###_OTHER_VERSIONS_DOCUMENTATION_BRANCH_###@$other_doc_version_branch@g" docs/config.ini
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new website how do we generate link to stable/dev one dynamically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ad-hoc replacement strings were used in the nav-bar of the old website to link to things like versions, api, tutorials, etc. These exact links don't exist on the new webpage, but their equivalent sections are handled by the sphinx build process automatically. I believe these only needed to be done this way because the links were hard coded in the config file, not built by sphinx.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Job PR-2924-f44ebae is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/f44ebae/index.html

Copy link
Collaborator

@tonyhoo tonyhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Thanks for the change and the new website looks great! Some minor comments regarding installation guide and build process

.github/workflow_scripts/build_all_docs.sh Show resolved Hide resolved
docs/ReleaseInstructions.md Show resolved Hide resolved

Download the PDF version with clickable links [multimodal-cheatsheet].

## Time Series
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we have the cheatsheet to be added for eda?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An EDA Cheat Sheet did not exist last time I synced with Alex. I'm not sure if Alex is planning on making one in the future.

# Uninstall libomp if it was previous installed
brew uninstall -f libomp
wget https://raw.githubusercontent.com/Homebrew/homebrew-core/fb8323f2b170bd4ae97e1bac9bf3e2983af3fdb0/Formula/libomp.rb
brew install libomp.rb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add rm libomp.rb after installation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I will add in next push

Comment on lines +5 to +6
# Install the proper version of PyTorch following https://pytorch.org/get-started/locally/
pip install torch==1.13.1+cu116 torchvision==0.14.1+cu116 --extra-index-url https://download.pytorch.org/whl/cu116
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we didn't need to manually install torch for GPU? Shouldn't it install automatically via pip install autogluon?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention was for these to be the exact same as they are on the existing website. I am not sure if your statement about not needing to manually install torch for GPU is correct but can look into it later.

Comment on lines +5 to +6
# Install the proper version of PyTorch following https://pytorch.org/get-started/locally/
pip install torch==1.13.1+cu116 torchvision==0.14.1+cu116 --extra-index-url https://download.pytorch.org/whl/cu116
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we didn't need to manually install torch for GPU? Shouldn't it install automatically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment


:::{dropdown} M1 and M2 Apple Silicon

Apple Silicon is now supported via the `conda` installation instructions outlined above. `conda-forge` will install the GPU version if a user's machine supports it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gradientsky please confirm if this is correct

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM! We can make smaller PRs for additional improvements & follow-ups after this is merged. Amazing work!

Copy link
Collaborator

@tonyhoo tonyhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Job PR-2924-ad09d55 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/ad09d55/index.html

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Job PR-2924-79b4e81 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/79b4e81/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Added some minor comments

docs/install-modules.md Outdated Show resolved Hide resolved
docs/install-modules.md Outdated Show resolved Hide resolved
docs/install-modules.md Outdated Show resolved Hide resolved
docs/install-modules.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Job PR-2924-0ff3285 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/0ff3285/index.html

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Job PR-2924-0ff3285 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2924/0ff3285/index.html

@gidler gidler merged commit db8a1b1 into master Mar 6, 2023
gidler added a commit to gidler/autogluon that referenced this pull request Mar 7, 2023
Co-authored-by: Oleksandr Shchur <shchuro@amazon.com>
@gidler gidler mentioned this pull request Mar 7, 2023
5 tasks
@Innixma Innixma modified the milestones: 0.7 Fast-Follow Items, 0.8 Release May 23, 2023
@Innixma Innixma deleted the new branch November 30, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API & Doc Improvements or additions to documentation model list checked You have updated the model list after modifying multimodal unit tests/docs priority: 0 Maximum priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants