[Post 0.7] [multimodal] Support xywh output for object detection #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANGAreNotGnu
added
the
model list checked
FANGAreNotGnu
changed the title
|
Job PR-2948-e6da785 is done. |
liangfu
requested changes
Feb 24, 2023
| predictor = MultiModalPredictor( | ||
| hyperparameters={ | ||
| "model.mmdet_image.checkpoint_name": checkpoint_name, | ||
| "model.mmdet_image.output_bbox_format": "xywh", |
There was a problem hiding this comment.
check functional equalvance of the two output formats, otherwise the test case would simply pass even without this hyperparameter.
There was a problem hiding this comment.
Good point, just updated the test
liangfu
approved these changes
Mar 1, 2023
|
Job PR-2948-0047ea1 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.