Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoMM] Fix terminal input hyperparameters #3048

Merged
merged 2 commits into from
Mar 16, 2023
Merged

[AutoMM] Fix terminal input hyperparameters #3048

merged 2 commits into from
Mar 16, 2023

Conversation

zhiqiangdon
Copy link
Contributor

Issue #, if available:

Description of changes:
Fix customizing hyperparameters through terminal commands.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

liangfu
liangfu approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@liangfu
Copy link
Collaborator

liangfu commented Mar 16, 2023

Would be better if you could add a unit test for capturing potential failures in the future.

@zhiqiangdon zhiqiangdon added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Mar 16, 2023
@zhiqiangdon
Copy link
Contributor Author

Would be better if you could add a unit test for capturing potential failures in the future.

Good suggestion! Added one test.

@github-actions
Copy link

Job PR-3048-70f8257 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3048/70f8257/index.html

@github-actions
Copy link

Job PR-3048-ded0260 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3048/ded0260/index.html

@zhiqiangdon zhiqiangdon merged commit 023c7e7 into autogluon:master Mar 16, 2023
@zhiqiangdon zhiqiangdon deleted the mm-fix branch March 16, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangfu liangfu liangfu approved these changes

Assignees
No one assigned
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhiqiangdon @liangfu