Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoMM] Fix NER HPO #3055

Merged
merged 4 commits into from
Mar 17, 2023
Merged

[AutoMM] Fix NER HPO #3055

merged 4 commits into from
Mar 17, 2023

Conversation

zhiqiangdon
Copy link
Contributor

Issue #, if available:

Description of changes:
filter_hyperparameters requires column type text_ner to keep the ner_text model. Post-process the column_types from infer_column_types to replace column type text with text_ner.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhiqiangdon zhiqiangdon added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Mar 16, 2023
liangfu
liangfu approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution. This unifies the HPO support for all problem types.

multimodal/src/autogluon/multimodal/predictor.py Outdated Show resolved Hide resolved
@github-actions
Copy link

Job PR-3055-2d73282 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3055/2d73282/index.html

cheungdaven
cheungdaven approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@cheungdaven cheungdaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhiqiangdon zhiqiangdon merged commit 4b7e0f4 into autogluon:master Mar 17, 2023
@zhiqiangdon zhiqiangdon deleted the mm-ner branch March 21, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangfu liangfu liangfu approved these changes

@cheungdaven cheungdaven cheungdaven approved these changes

Assignees
No one assigned
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhiqiangdon @liangfu @cheungdaven