-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[timeseries] Implement OOF prediction caching #3062
Conversation
69cc333
to
703798c
Compare
Job PR-3062-d9c1ac8 is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! added some comments.
timeseries/src/autogluon/timeseries/models/abstract/abstract_timeseries_model.py
Outdated
Show resolved
Hide resolved
timeseries/src/autogluon/timeseries/models/gluonts/abstract_gluonts.py
Outdated
Show resolved
Hide resolved
timeseries/src/autogluon/timeseries/trainer/abstract_trainer.py
Outdated
Show resolved
Hide resolved
timeseries/src/autogluon/timeseries/models/abstract/abstract_timeseries_model.py
Outdated
Show resolved
Hide resolved
d9c1ac8
to
ae4fb13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Job PR-3062-47b8cfd is done. |
This is part 1 of the improved multi-window backtesting for time series (part 2: #3051).
Description of changes:
predict
on theval_data
once for all models. This saves training time and deals with the fact that predictions are non-deterministic for some models.AbstractTimeSeriesModel
andAbstractTimeSeriesTrainer
AutoGluonTabularModel
would create an empty directory at initialization.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.