Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoMM] Upgrade torchmetrics #3081

Merged
merged 7 commits into from
Mar 31, 2023
Merged

[AutoMM] Upgrade torchmetrics #3081

merged 7 commits into from
Mar 31, 2023

Conversation

zhiqiangdon
Copy link
Contributor

@zhiqiangdon zhiqiangdon commented Mar 27, 2023 •
edited

Issue #, if available:
https://github.com/Lightning-AI/metrics/releases/tag/v0.10.0
scikit-learn/scikit-learn#25990

Description of changes:

  1. Update using the new APIs of torchmetrics' classification metrics.
  2. For >= v0.10, torchmetrics assumes the positive label is 1 (https://torchmetrics.readthedocs.io/en/stable/classification/auroc.html#binaryauroc). Add a new label encoder class to make sure the positive class is always 1 in the binary case.
  3. Unit tests for the customized label encoder.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhiqiangdon zhiqiangdon added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Mar 27, 2023
@github-actions
Copy link

Job PR-3081-a740ae0 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3081/a740ae0/index.html

FANGAreNotGnu
FANGAreNotGnu approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@FANGAreNotGnu FANGAreNotGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cheungdaven
cheungdaven reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@cheungdaven cheungdaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhiqiangdon zhiqiangdon merged commit cada0c7 into autogluon:master Mar 31, 2023
@zhiqiangdon zhiqiangdon deleted the mm-metric branch April 4, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheungdaven cheungdaven cheungdaven approved these changes

@FANGAreNotGnu FANGAreNotGnu FANGAreNotGnu approved these changes

@yongxinw yongxinw Awaiting requested review from yongxinw

@liangfu liangfu Awaiting requested review from liangfu

@tonyhoo tonyhoo Awaiting requested review from tonyhoo

@suzhoum suzhoum Awaiting requested review from suzhoum

@gidler gidler Awaiting requested review from gidler

Assignees
No one assigned
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhiqiangdon @cheungdaven @FANGAreNotGnu