-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximum resources #3142
Maximum resources #3142
Conversation
Job PR-3142-7a800f8 is done. |
tabular/src/autogluon/tabular/models/tabular_nn/torch/tabular_nn_torch.py
Outdated
Show resolved
Hide resolved
tabular/src/autogluon/tabular/models/fastainn/tabular_nn_fastai.py
Outdated
Show resolved
Hide resolved
tabular/src/autogluon/tabular/models/tabular_nn/torch/tabular_nn_torch.py
Outdated
Show resolved
Hide resolved
total_resources: Optional[Dict[str, Union[int, float]]] = None, | ||
parallel_hpo: bool = False, | ||
**kwargs | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docstring explaining this, add return type
return kwargs | ||
|
||
def _preprocess_fit_resources(self, silent=False, total_resources=None, parallel_hpo=False, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add return type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added a few minor comments
return kwargs | ||
|
||
def _preprocess_fit_resources(self, silent=False, total_resources=None, parallel_hpo=False, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add type hints
Job PR-3142-bd6372d is done. |
Merging as unit tests for previous commits have passed, the most recent commit only added comments |
Job PR-3142-f76a039 is done. |
Job PR-3142-178cf94 is done. |
Job PR-3142-d22642f is done. |
Issue #, if available:
torch models training will be slowed by the usage of virtual cores.
Description of changes:
Example run output with a newly launched cluster of 8 m5.24xlarge machine:
The training time matches a local run and appear to be normal now
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.