Tabular: Raise regression pred_proba #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-3240-5413439 is done. |
gradientsky
approved these changes
May 26, 2023
Comment on lines
9
to
13
| """Simple class that holds information on what a problem type is capable of doing""" | ||
| def __init__(self, | ||
| can_predict: bool, | ||
| can_predict_proba: bool, | ||
| is_classification: bool): |
| @@ -1338,7 +1346,7 @@ def fit_pseudolabel(self, pseudo_data: pd.DataFrame, max_iter: int = 5, return_p | |||
| self.fit_weighted_ensemble() | |||
|
|
|||
| if return_pred_prob: | |||
| y_pred_proba = self.predict_proba(pseudo_data) | |||
| y_pred_proba = self.predict_proba(pseudo_data) if self.can_predict_proba else self.predict(pseudo_data) | |||
There was a problem hiding this comment.
nit: split into if-else to have consistency vs other places?
There was a problem hiding this comment.
Will keep for now, it will be unified once we apply black in future
|
Job PR-3240-204271c is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #2685
Description of changes:
Update
TabularPredictorto raise an AssertionError whenpredict_probaandpredict_proba_multiare called when the problem type isregressionorquantile. This aligns the logic withMultimodalPredictor.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.