Fix plot ensemble model on Windows #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Innixma
reviewed
Jun 3, 2023
Innixma
reviewed
Jun 3, 2023
| @@ -111,6 +111,7 @@ def test_advanced_functionality(): | |||
| savedir_predictor_original = savedir + 'predictor/' | |||
| predictor: TabularPredictor = TabularPredictor(label=label, path=savedir_predictor_original).fit(train_data) | |||
| leaderboard = predictor.leaderboard(data=test_data) | |||
| predictor.plot_ensemble_model() | |||
There was a problem hiding this comment.
we need to install pygraphviz for unit tests to work, it isn't installed by default.
There was a problem hiding this comment.
I see. it might be tricky to install this in our CI env as it requires some C++ library. I'll take a look
Innixma
reviewed
Jun 6, 2023
| @@ -219,6 +220,7 @@ def test_advanced_functionality(): | |||
|
|
|||
| assert(predictor.get_model_full_dict() == dict()) | |||
| predictor.refit_full() | |||
| predictor.plot_ensemble_model() | |||
There was a problem hiding this comment.
can check that the output file exists on disk, probably that is good enough for testing purposes
|
Job PR-3259-2efc65f is done. |
Innixma
approved these changes
Jun 7, 2023
|
Have tested on Windows. Will merge now |
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1065
Description of changes:
\\separator on Windows as escape character.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.