Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CatBoost to 1.2 #3268

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Update CatBoost to 1.2 #3268

merged 2 commits into from
Jun 6, 2023

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Jun 3, 2023 •
edited

Issue #, if available:

Description of changes:
Update CatBoost to 1.2

  • CatBoost 1.2 has 8% faster training speed in multiclass classification with the log loss metric.
  • Will plan to benchmark after merge on mainline during code freeze instead of benchmarking this PR individually, as it will be easy to isolate the root cause of regressions in case this PR is the cause.

TODO:

  • Run the CI on Windows/MacOS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added module: tabular dependency Related to dependency packages labels Jun 3, 2023
@Innixma Innixma added this to the 0.8 Release milestone Jun 3, 2023
@Innixma Innixma requested review from yinweisu and shchur June 3, 2023 22:34
@Innixma
Copy link
Contributor Author

Innixma commented Jun 4, 2023

@shchur Unit test failed in TimeSeries. Looks to be potentially unrelated to this PR?

@shchur
Copy link
Collaborator

shchur commented Jun 4, 2023

@Innixma rebasing should fix this, the bugfix was merged in #3255

@Innixma
Copy link
Contributor Author

Innixma commented Jun 5, 2023

@shchur My branch already has that PR merged in, so the CI issue happened post-fix.

@shchur
Copy link
Collaborator

shchur commented Jun 5, 2023

Should be fixed by #3275

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Job PR-3268-f6cee70 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3268/f6cee70/index.html

yinweisu
yinweisu requested changes Jun 5, 2023
View reviewed changes
tabular/setup.py Outdated
'catboost>=1.1,<1.2',
# CatBoost wheel build is not working correctly on darwin for CatBoost 1.2 on Python 3.8, so use old version in this case.
# https://github.com/autogluon/autogluon/pull/3190#issuecomment-1540599280
'catboost>=1.1,<1.2 ; python_version <= "3.8" and sys_platform == "darwin"',
Copy link
Collaborator

@yinweisu yinweisu Jun 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did some testing on all python 3.8 - 3.10 with macos, and all of them fail to install catboost 1.2.
Let's just not do it for macos no matter which python version it is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking! I've updated the PR so that it should avoid installing 1.2 on MacOS, if you can give another try or we can run platform tests

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Job PR-3268-e049c0a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3268/e049c0a/index.html

yinweisu
yinweisu approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@yinweisu yinweisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinweisu
Copy link
Collaborator

yinweisu commented Jun 6, 2023 •
edited

/platform_tests
Platform Tests Output

@Innixma Innixma merged commit e9dcdf0 into autogluon:master Jun 6, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinweisu yinweisu yinweisu approved these changes

@shchur shchur Awaiting requested review from shchur

Assignees
No one assigned
Labels
dependency Related to dependency packages module: tabular
Projects
None yet
Milestone
0.8 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Innixma @shchur @yinweisu