[multimodal] wrap the dataset_mmlab/__init__.py with try except #3277
Conversation
|
Job PR-3277-181621d is done. |
| from .multi_image_mix_dataset import MultiImageMixDataset | ||
| try: | ||
| from .multi_image_mix_dataset import MultiImageMixDataset | ||
| except ImportError: |
There was a problem hiding this comment.
Is it supposed to be ImportError? The error message looks like: NameError: name BaseTransform is not defined.
There was a problem hiding this comment.
It's ImportError. Previously we set BaseTransform=None if import failed
There was a problem hiding this comment.
A safer way may be just removing ImportError. Remember double-checking the installation for the nightly build.
There was a problem hiding this comment.
By default, mmlab packages are not installed
There was a problem hiding this comment.
We have the installation check if mmdet is used.
There was a problem hiding this comment.
Right. Also need to check whether the nightly build works without installing the mmlab packages.
There was a problem hiding this comment.
Sure. I'll check with my repo again and will merge this if it works correctly.
There was a problem hiding this comment.
Checked for this branch in a new virtual environment (Linux). For object detection it shows installation guidance correctly, and for other tasks it works correctly as well.
Address the comments in #3266
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.