Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix platform tests #3285

Merged
merged 10 commits into from
Jun 8, 2023
Merged

Fix platform tests #3285

merged 10 commits into from
Jun 8, 2023

Conversation

yinweisu
Copy link
Collaborator

@yinweisu yinweisu commented Jun 6, 2023 •
edited

Issue #, if available:

Description of changes:

  • install fail because of setup_mmcv.sh not being found. Change to use install_all.sh now as we don't need mxnet anymore
  • fix tempfile path. str(tempfile) doesn't give a string but still the object itself for some reason causing issue on Windows. Tried to use tempfile.name instead but the underlying issue with TemporaryFile is that it opens the file automatically, while our saving logic tries to open it again. This will fail on Windows. Change to create a tempdir instead

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 6, 2023 •
edited

/platform_tests ref=fix_platform_tests
Platform Tests Output

@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 6, 2023 •
edited

/platform_tests ref=fix_platform_tests
Platform Tests Output

@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 6, 2023 •
edited

/platform_tests ref=fix_platform_tests
Platform Tests Output

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Job PR-3285-91407e4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/91407e4/index.html

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Job PR-3285-2611808 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/2611808/index.html

@yinweisu yinweisu marked this pull request as ready for review June 7, 2023 16:40
@yinweisu yinweisu closed this Jun 7, 2023
@yinweisu yinweisu reopened this Jun 7, 2023
@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 7, 2023 •
edited

/platform_tests ref=fix_platform_tests
Platform Tests Output

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Job PR-3285-a3d5e4f is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/a3d5e4f/index.html

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Job PR-3285-a3d5e4f is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/a3d5e4f/index.html

shchur
shchur approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@shchur shchur left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this!

Added some comments/suggestions, but feel free to merge if my suggestion doesn't work.

common/tests/unittests/test_hash_pandas_df.py Outdated Show resolved Hide resolved
common/tests/unittests/test_hash_pandas_df.py Show resolved Hide resolved
@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 7, 2023 •
edited

/platform_tests ref=fix_platform_tests
Platform Tests Output

@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 7, 2023 •
edited

/platform_tests ref=fix_platform_tests

Platform Tests Output

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Job PR-3285-732e681 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/732e681/index.html

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Job PR-3285-83ec4c0 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/83ec4c0/index.html

@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 8, 2023 •
edited

/platform_tests ref=fix_platform_tests
Platform Tests Output

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Job PR-3285-0dd9473 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/0dd9473/index.html

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Job PR-3285-ecbd613 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/ecbd613/index.html

@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 8, 2023 •
edited

/platform_tests ref=fix_platform_tests
Platform Tests Output

@yinweisu
Copy link
Collaborator Author

yinweisu commented Jun 8, 2023 •
edited

/platform_tests ref=fix_platform_tests

Platform Tests Output

@yinweisu yinweisu merged commit 9c525e0 into master Jun 8, 2023
103 of 106 checks passed
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Job PR-3285-2026846 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3285/2026846/index.html

@Innixma Innixma deleted the fix_platform_tests branch November 30, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shchur shchur shchur approved these changes

@FANGAreNotGnu FANGAreNotGnu Awaiting requested review from FANGAreNotGnu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yinweisu @shchur