Add enable_categorical=True support to XGBoost #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradientsky
reviewed
Jun 7, 2023
| if is_train: | ||
| self._ohe_generator.fit(X) | ||
| if self._ohe: | ||
| if self._ohe_generator is None: |
There was a problem hiding this comment.
If the model is re-trained (i.e. on the full data), wouldn't this reuse the generator. I think it's better to always create a new one if is_train and self._ohe.
There was a problem hiding this comment.
No, re-training would be a new class instance, it does not cause issues
| self._ohe = False | ||
| else: | ||
| """One-hot-encode categorical features""" | ||
| self._ohe = True | ||
|
|
There was a problem hiding this comment.
nit:
self._ohe = not enable_categoricalThere was a problem hiding this comment.
Good point, but will keep as is since I have docstrings to describe what True and False mean inline.
|
Note: CI failures are from AutoMM, unrelated to this PR. All tabular tests and CI builds succeeded. |
gradientsky
approved these changes
Jun 7, 2023
|
Job PR-3286-80d04e3 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #2429
Description of changes:
enable_categorical=True.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.