Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path logic #3293

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix path logic #3293

merged 1 commit into from
Jun 9, 2023

Conversation

yinweisu
Copy link
Collaborator

@yinweisu yinweisu commented Jun 8, 2023

Issue #, if available:

Description of changes:

  • Tabular: Fix crash when save path is absolute #3288 introduce logic for saving relative paths for models. This logic affects timeseries too and Trainer in timeseries is not being updated with the relative path logic. This could be an issue in some edge cases, for example:
`current_working_dir` is `/home/ubuntu/user/test`
`path` specified to predictor is `/home/ubuntu/timeseries`

`model_paths` after training will contain `../timeseries/model/XXX`
while the `path` being saved in trainer is `/home/ubuntu/timeseries`
Then when we try to find common prefix to reset the context, it fails as there's no common prefix

Convert trainer's `path` to be relative like what `TabularPredictor` should solve the problem

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yinweisu yinweisu requested a review from Innixma June 8, 2023 22:32
Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Innixma Innixma added this to the 0.8 Release milestone Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Job PR-3293-c6baacd is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3293/c6baacd/index.html

@yinweisu yinweisu merged commit 4a19f7c into autogluon:master Jun 9, 2023
28 checks passed
@yinweisu yinweisu deleted the fix_timeseries_path branch June 9, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants