Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix predict_multi crashing when inverse_transform=False #3294

Merged

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Jun 9, 2023

Issue #, if available:

Description of changes:

  • Fix predict_multi crashing when inverse_transform=False, as_pandas=True
  • Fix predict_proba_multi crashing when inverse_transform=False, as_pandas=True and dropped classes exist.
  • Unified post-processing code between predict and predict_multi.
  • Unified post-processing code between predict_proba and predict_proba_multi.
  • Added additional unit tests for predict_multi and predict_proba_multi

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added bug Something isn't working module: tabular priority: 0 Maximum priority labels Jun 9, 2023
@Innixma Innixma added this to the 0.8 Release milestone Jun 9, 2023
@Innixma Innixma requested a review from yinweisu June 9, 2023 00:03
Copy link
Collaborator

@yinweisu yinweisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Job PR-3294-176c663 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3294/176c663/index.html

@Innixma Innixma merged commit a25d5f3 into autogluon:master Jun 9, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: tabular priority: 0 Maximum priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants