Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] Remove all references to MXNet #3396

Merged
merged 5 commits into from Jul 18, 2023

Conversation

shchur
Copy link
Collaborator

@shchur shchur commented Jul 13, 2023

Issue #, if available: #3357

MXNet models are incompatible with AutoGluon out-of-the-box because of numpy versions: MXNet requires numpy<=1.20 and AutoGluon requires numpy>=1.21. This PR removes all references to MXNet models, including documentation.

Description of changes:

  • Remove all references to MXNet from code, tests and documentation.
  • Merge AbstractGluonTSModel and AbstractGluonTSPyTorchModel into a single class AbstractGluonTSModel, as only PyTorch models from GluonTS will be supported from now on.
  • Notify user if MXNet models are present in the hyperparameters dictionary

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Job PR-3396-a39d778 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3396/a39d778/index.html

@shchur shchur requested a review from tonyhoo July 13, 2023 15:17
@@ -181,28 +181,8 @@ Note that some of the models' hyperparameters have names and default values that

## MXNet Models

Following MXNet-based models from GluonTS are available in AutoGluon.
MXNet models from GluonTS have been deprecated as of AutoGluon v0.9 because of dependency conflicts caused by MXNet.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will skip 0.9 and do 1.0 release directly this year, @Innixma can confirm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@github-actions
Copy link

Job PR-3396-44a8f04 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3396/44a8f04/index.html

@shchur shchur merged commit 2f83130 into autogluon:master Jul 18, 2023
29 checks passed
@shchur shchur deleted the remove-mxnet branch July 18, 2023 07:18
ddelange added a commit to ddelange/autogluon that referenced this pull request Jul 26, 2023
* 'master' of https://github.com/awslabs/autogluon:
  Fix crash when `time_limit` is None and overwritten via `max_time_limit` (autogluon#3418)
  Upgrade torch 2.0 (autogluon#3404)
  Fix FastAI crash edge-case (autogluon#3416)
  Add log for fit time adjustments (autogluon#3408)
  [fix][eda] Anomaly Detection - disable bps_flag for SUOD (autogluon#3406)
  [timeseries] Remove all references to MXNet (autogluon#3396)
  Remove ray lightning (autogluon#3398)
  [AutoMM] Add unit tests for trimming sequence lengths (autogluon#3399)
  [FIX] fix detection tutorial index (autogluon#3397)
  Refactor path (autogluon#3355)
  [Doc] Add AutoMM FAQs (autogluon#3388)
  [AutoMM] Fix the input keys of categorical MLP (autogluon#3384)
  [AutoMM] Clean up text processor (autogluon#3383)
  [AutoMM] Support customizing use_fast for AutoTokenizer (autogluon#3379)
  vw version bump (autogluon#3373)
  0.8.2 post release (autogluon#3377)
@shchur shchur added module: timeseries related to the timeseries module breaking Breaking changes to the public API labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes to the public API module: timeseries related to the timeseries module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants