Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [Tabular] Integrating Bench and Dashboard in CI #3527

Merged
merged 36 commits into from Sep 15, 2023

Conversation

prateekdesai04
Copy link
Contributor

Description of changes:
Feature addition, integration of AG Bench with AG Dashboard.
Now, a contributor can benchmark their PRs and get a visualization of comparison w.r.t latest benchmark run on master branch

Link to test runs:

Benchmark on master branch
https://github.com/prateekdesai04/autogluon/actions/runs/6192027450

Benchmark + Evaluation on dev branch
https://github.com/prateekdesai04/autogluon/actions/runs/6192306818

Link to slash command dispatch
prateekdesai04#20 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@prateekdesai04 prateekdesai04 changed the title [Feature] Integrating of Bench and Dashboard in CI [Feature] [Tabular] Integrating Bench and Dashboard in CI Sep 15, 2023
@github-actions
Copy link

Job PR-3527-4d232c7 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3527/4d232c7/index.html

.github/workflows/benchmark-command.yml Show resolved Hide resolved
@@ -143,4 +170,3 @@ jobs:
repository: ${{ github.event.inputs.repository }}
comment-id: ${{ github.event.inputs.comment-id }}
body: ${{ steps.website.outputs.body }}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new line

push:
branches: ["master"]
schedule:
- cron: '0 0 * * 0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to be around 2am in the morning PST. By default, this is UTC time


env:
AG_MODULE: tabular
AG_PRESET: medium
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to discuss with the team 1. how frequent we want to run the benchmark 2. what preset we want to compare (running all presets are expensive) 3. what benchmark we want to run (current just test, which is dummy). For now this is good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, will add it as a parking lot for today

@@ -35,6 +35,7 @@ jobs:
token: ${{ secrets.PAT }}
commands: |
benchmark
benchmark_master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this does anything and it's not needed too. Master won't be triggered by slash command

@github-actions
Copy link

Job PR-3527-d40926c is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3527/d40926c/index.html

@github-actions
Copy link

Job PR-3527-11e5e38 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3527/11e5e38/index.html

Copy link
Collaborator

@yinweisu yinweisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@prateekdesai04 prateekdesai04 merged commit c44a7fe into autogluon:master Sep 15, 2023
28 checks passed
ddelange added a commit to ddelange/autogluon that referenced this pull request Sep 18, 2023
* 'master' of https://github.com/awslabs/autogluon:
  [Lightning] Update lightning import (autogluon#3526)
  [Feature] [Tabular] Integrating Bench and Dashboard in CI (autogluon#3527)
  [timeseries] Automatically remove short time series from training data (autogluon#3469)
  [timeseries] Fix timeseries tutorial on Colab (autogluon#3522)
  [AutoMM] Support torch.compile() (autogluon#3520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants