Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoMM] Fix the bug when introducing PEFT methods that do not require adding additional parameters. #3840

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

Harry-zzh
Copy link
Collaborator

Issue #, if available:

Description of changes:

  • Classify PEFT methods into two categories: additive (e.g. LoRA) and non-additive (e.g. BitFit).
  • Modify function "apply_model_adaptation" to apply only to additive PEFT methods.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

Job PR-3840-acbfb0f is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3840/acbfb0f/index.html

@tonyhoo tonyhoo added the run-multi-gpu Run multimodal multi-gpu tests label Jan 5, 2024
@zhiqiangdon zhiqiangdon added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Jan 13, 2024
Copy link

Job PR-3840-a756dc9 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3840/a756dc9/index.html

Copy link
Contributor

@zhiqiangdon zhiqiangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiangdon zhiqiangdon merged commit 2f99995 into autogluon:master Jan 16, 2024
42 of 43 checks passed
@Harry-zzh Harry-zzh deleted the fix_peft branch January 17, 2024 02:10
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
…e adding additional parameters. (autogluon#3840)

Co-authored-by: Ubuntu <ubuntu@ip-172-31-3-160.us-west-2.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs run-multi-gpu Run multimodal multi-gpu tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants