[Tabular] Removing scikit-learn upgrade cap and handling failures in DecisionTreeRegressor #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-3881-a399ce8 is done. |
Innixma
approved these changes
Jan 25, 2024
LennartPurucker
pushed a commit
to LennartPurucker/autogluon
that referenced
this pull request
Jun 1, 2024
…DecisionTreeRegressor (autogluon#3881) Co-authored-by: Ubuntu <ubuntu@ip-172-31-9-154.us-west-2.compute.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: A follow-up PR on #3872
Description of changes: This PR handles the failures that are produced as a result of upgrading to
scikit-learn 1.4.0.Currently, the way we fix this is re-calculate
y_train_andy_train_leaves_in DecisionTreeRegressor and make the object similar to what it was when we were usingscikit-learn 1.3.2. This might be updated if we find a better fix in the future.Link to detailed discussion about the issue: #3872 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.