Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 3899, call self.save after update _time_fit_training, add t… #3900

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

afmkt
Copy link
Contributor

@afmkt afmkt commented Feb 4, 2024

fix issue #3899 TimeSeriesPredictor.info raises exception when called after calling TimeSeriesPredictor.load

Issue #3899 :

Description of changes:

file changes
timeseries/src/autogluon/timeseries/learner.py call self.save() after update self._time_fit_training
timeseries/tests/unittests/test_predictor.py add test_load_predictor_then_info_works to cover issue #3899
full_install.bat copied from full_install.sh to facilitate installation in Windows

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma requested a review from shchur February 13, 2024 18:21
@Innixma Innixma added this to the 1.0.1 Release milestone Feb 13, 2024
@Innixma Innixma added bug Something isn't working OS: Windows Impacting Windows OS module: timeseries related to the timeseries module labels Feb 13, 2024
Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @afmkt!

afmkt and others added 3 commits February 15, 2024 09:17
…est case to cover the issue, add bat file to facilitate installation under windows
@shchur shchur merged commit b713bd3 into autogluon:master Feb 15, 2024
26 checks passed
Copy link

Job PR-3900-c3ad135 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3900/c3ad135/index.html

@Innixma Innixma modified the milestones: 1.0.1 Release, 1.1 Release Apr 5, 2024
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: timeseries related to the timeseries module OS: Windows Impacting Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants