Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[timeseries] Add Chronos pretrained forecasting model #3978

Merged
merged 26 commits into from
Mar 24, 2024
Merged

[timeseries] Add Chronos pretrained forecasting model #3978

merged 26 commits into from
Mar 24, 2024

Conversation

canerturkmen
Copy link
Contributor

@canerturkmen canerturkmen commented Mar 13, 2024 •
edited

Issue #, if available:

Description of changes:

Add Chronos, a pretrained time series model for forecasting.

Remaining todos:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@canerturkmen canerturkmen added the module: timeseries related to the timeseries module label Mar 13, 2024
@canerturkmen canerturkmen marked this pull request as draft March 13, 2024 10:31
@canerturkmen canerturkmen mentioned this pull request Mar 14, 2024
Closed
@canerturkmen canerturkmen added run-multi-gpu Run multimodal multi-gpu tests module: multimodal labels Mar 15, 2024
@canerturkmen canerturkmen mentioned this pull request Mar 15, 2024
Merged
@canerturkmen canerturkmen removed module: multimodal run-multi-gpu Run multimodal multi-gpu tests labels Mar 15, 2024
@canerturkmen canerturkmen added this to the 1.1 Release milestone Mar 15, 2024
@github-actions GitHub Actions
Copy link

Job PR-3978-8152db6 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3978/8152db6/index.html

@abdulfatir abdulfatir mentioned this pull request Mar 15, 2024
Open
shchur
shchur reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and thanks for the amazing CPU inference speed optimizations!

My main question is related to merging skip_validation and disable_length_check kwargs, the rest are minor comments.

timeseries/setup.py Outdated Show resolved Hide resolved
timeseries/setup.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/configs/presets_configs.py Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Job PR-3978-ba840fb is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3978/ba840fb/index.html

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run

@github-actions GitHub Actions
Copy link

Job PR-3978-ccf780f is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3978/ccf780f/index.html

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run
numba==0.59.0 numba==0.59.1
numba==0.59.0 numba==0.59.1

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run
botocore==1.34.65 botocore==1.34.66
boto3==1.34.65 boto3==1.34.66
botocore==1.34.65 botocore==1.34.66
boto3==1.34.65 boto3==1.34.66

@github-actions GitHub Actions
Copy link

Job PR-3978-771b546 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3978/771b546/index.html

shchur
shchur reviewed Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks from my side, I think we are almost there. Also the tests are a work of art 💪

timeseries/src/autogluon/timeseries/configs/presets_configs.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/configs/presets_configs.py Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/chronos.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/models/chronos/model.py Outdated Show resolved Hide resolved
timeseries/src/autogluon/timeseries/predictor.py Show resolved Hide resolved
timeseries/tests/unittests/models/test_chronos.py Show resolved Hide resolved
timeseries/tests/unittests/models/test_chronos.py Outdated Show resolved Hide resolved
timeseries/tests/unittests/models/test_models.py Outdated Show resolved Hide resolved
@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run

@github-actions GitHub Actions
Copy link

Job PR-3978-8f8711a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3978/8f8711a/index.html

canerturkmen and others added 3 commits March 21, 2024 06:09
@canerturkmen @lostella @shchur
[timeseries] add Chronos pretrained model
00be2a9 
Co-authored-by: Lorenzo Stella <stellalo@amazon.com>
Co-authored-by: Oleksandr Shchur <shchuro@amazon.com>
@canerturkmen
started adding unit tests
3a5ceb7
@canerturkmen
revert transformer version changes to multimodal
88d88f5
@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run

@canerturkmen
Copy link
Contributor Author

/platform_tests ref=add-chronos

@github-actions GitHub Actions
Copy link

Job PR-3978-ed0aa01 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3978/ed0aa01/index.html

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run
graphviz==0.20.2 graphviz==0.20.3
graphviz==0.20.2 graphviz==0.20.3

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run

@canerturkmen canerturkmen force-pushed the add-chronos branch 2 times, most recently from 9423a05 to ed0aa01 Compare March 21, 2024 16:40
@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run

@canerturkmen canerturkmen marked this pull request as ready for review March 21, 2024 19:02
@canerturkmen
Copy link
Contributor Author

@shchur Ready for your final review! 🚀

@github-actions GitHub Actions
Copy link

Job PR-3978-e6e52e9 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3978/e6e52e9/index.html

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run
typer==0.9.0 typer==0.9.4
typer==0.9.0 typer==0.9.4

@github-actions GitHub Actions
Copy link

Job PR-3978-1d68975 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3978/1d68975/index.html

shchur
shchur approved these changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@shchur shchur merged commit c53adef into autogluon:master Mar 24, 2024
29 checks passed
@canerturkmen canerturkmen deleted the add-chronos branch March 25, 2024 09:09
prateekdesai04 pushed a commit to prateekdesai04/autogluon that referenced this pull request Apr 3, 2024
@canerturkmen @lostella @shchur
[timeseries] Add Chronos pretrained forecasting model (autogluon#3978)
4d7c8d4 
Co-authored-by: Lorenzo Stella <stellalo@amazon.com>
Co-authored-by: Oleksandr Shchur <shchuro@amazon.com>
@Martin-Molinero Martin-Molinero mentioned this pull request May 29, 2024
Closed
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
@canerturkmen @lostella
@shchur @LennartPurucker
[timeseries] Add Chronos pretrained forecasting model (autogluon#3978)
f23606c 
Co-authored-by: Lorenzo Stella <stellalo@amazon.com>
Co-authored-by: Oleksandr Shchur <shchuro@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shchur shchur shchur approved these changes

@tonyhoo tonyhoo Awaiting requested review from tonyhoo

Assignees
No one assigned
Labels
module: timeseries related to the timeseries module
Projects
None yet
Milestone
1.1 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@canerturkmen @yinweisu @shchur