-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoMM] Fix conv-lora example #4022
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Job PR-4022-57a782a is done. |
@@ -56,6 +56,13 @@ def expand_path(df, dataset_dir): | |||
parser.add_argument("--num_gpus", type=int, default=1) | |||
parser.add_argument("--output_dir", type=str, default="outputs") | |||
parser.add_argument("--ckpt_path", type=str, default="outputs", help="Checkpoint path.") | |||
parser.add_argument("--per_gpu_batch_size", type=int, default="8", help="The batch size for each GPU.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we follow the default batch size setting of Conv-LoRA paper?
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.