Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoMM] Fix conv-lora example #4022

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

zhiqiangdon
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. Install from source to improve the flexibility of users.
  2. Remove fixed model path to avoid errors when running different datasets.
  3. Support customizing per_gpu_batch_size and batch_size.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhiqiangdon zhiqiangdon added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Apr 1, 2024
@yinweisu
Copy link
Collaborator

yinweisu commented Apr 1, 2024

Previous CI Run Current CI Run
PyWavelets==1.5.0 PyWavelets==1.6.0
ruff==0.3.4 ruff==0.3.5
Werkzeug==3.0.1 Werkzeug==3.0.2
PyWavelets==1.5.0 PyWavelets==1.6.0
ruff==0.3.4 ruff==0.3.5
Werkzeug==3.0.1 Werkzeug==3.0.2

Copy link
Contributor

@FANGAreNotGnu FANGAreNotGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Apr 1, 2024

Job PR-4022-57a782a is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4022/57a782a/index.html

@zhiqiangdon zhiqiangdon merged commit 74e82e6 into autogluon:master Apr 1, 2024
29 checks passed
@@ -56,6 +56,13 @@ def expand_path(df, dataset_dir):
parser.add_argument("--num_gpus", type=int, default=1)
parser.add_argument("--output_dir", type=str, default="outputs")
parser.add_argument("--ckpt_path", type=str, default="outputs", help="Checkpoint path.")
parser.add_argument("--per_gpu_batch_size", type=int, default="8", help="The batch size for each GPU.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we follow the default batch size setting of Conv-LoRA paper?

@zhiqiangdon zhiqiangdon deleted the conv-lora-example branch April 2, 2024 04:19
prateekdesai04 pushed a commit to prateekdesai04/autogluon that referenced this pull request Apr 3, 2024
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants