Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Dependency Ranges for 1.1 #4024

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Upgrade Dependency Ranges for 1.1 #4024

merged 3 commits into from
Apr 5, 2024

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Apr 2, 2024 •
edited

Issue #, if available:

Description of changes:

  • Upgrade Dependency Ranges for 1.1
  • Update pandas to 2.2.x has been moved to a future PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 1.1 Release milestone Apr 2, 2024
@Innixma Innixma changed the title Upgrade Dependency Ranges for 1.1 [WIP] Upgrade Dependency Ranges for 1.1 Apr 2, 2024
@yinweisu
Copy link
Collaborator

yinweisu commented Apr 2, 2024

Previous CI Run Current CI Run

1 similar comment
@yinweisu
Copy link
Collaborator

yinweisu commented Apr 2, 2024

Previous CI Run Current CI Run

@Innixma Innixma mentioned this pull request Apr 2, 2024
Closed
23 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Job PR-4024-e9df282 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4024/e9df282/index.html

@Innixma Innixma requested review from shchur and zhiqiangdon and removed request for shchur and zhiqiangdon April 2, 2024 21:32
@Innixma Innixma changed the title [WIP] Upgrade Dependency Ranges for 1.1 Upgrade Dependency Ranges for 1.1 Apr 4, 2024
@yinweisu
Copy link
Collaborator

yinweisu commented Apr 4, 2024

Previous CI Run Current CI Run

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Job PR-4024-3be6fb4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4024/3be6fb4/index.html

shchur
shchur reviewed Apr 5, 2024
View reviewed changes
core/src/autogluon/core/_setup_utils.py Outdated
@@ -18,7 +18,7 @@
DEPENDENT_PACKAGES = {
"boto3": ">=1.10,<2", # <2 because unlikely to introduce breaking changes in minor releases. >=1.10 because 1.10 is 3 years old, no need to support older
"numpy": ">=1.21,<1.29", # "<{N+3}" upper cap, where N is the latest released minor version, assuming no warnings using N
"pandas": ">=2.0.0,<2.2.0", # "<{N+1}" upper cap
"pandas": ">=2.0.0,<2.3.0", # "<{N+1}" upper cap
Copy link
Collaborator

@shchur shchur Apr 5, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pandas 2.2 introduced a breaking change to how time frequency aliases are represented as strings (https://pandas.pydata.org/docs/whatsnew/v2.2.0.html#other-deprecations). For example, pandas.tseries.frequencies.to_offset("1min") returns

  • min in pandas >=2.2
  • T in pandas <2.2

I will need to change our logic for detecting seasonality to take this into account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving pandas upgrade to a separate PR to isolate the change

@Innixma Innixma changed the title Upgrade Dependency Ranges for 1.1 [DO NOT MERGE] Upgrade Dependency Ranges for 1.1 Apr 5, 2024
@Innixma Innixma added the priority: 0 Maximum priority label Apr 5, 2024
@Innixma Innixma changed the title [DO NOT MERGE] Upgrade Dependency Ranges for 1.1 Upgrade Dependency Ranges for 1.1 Apr 5, 2024
@Innixma Innixma added the dependency Related to dependency packages label Apr 5, 2024
suzhoum
suzhoum approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@suzhoum suzhoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Innixma Innixma merged commit db4821c into autogluon:master Apr 5, 2024
5 checks passed
prateekdesai04
prateekdesai04 reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@prateekdesai04 prateekdesai04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Innixma Innixma mentioned this pull request Apr 5, 2024
Closed
4 tasks
@yinweisu
Copy link
Collaborator

yinweisu commented Apr 5, 2024

Previous CI Run Current CI Run
vowpalwabbit==9.9.0 vowpalwabbit==9.8.0
skl2onnx==1.16.0 skl2onnx==1.15.0
vowpalwabbit==9.9.0 vowpalwabbit==9.8.0
skl2onnx==1.16.0 skl2onnx==1.15.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Job PR-4024-5662cb4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4024/5662cb4/index.html

LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
@Innixma @LennartPurucker
Upgrade Dependency Ranges for 1.1 (autogluon#4024)
1ea7147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shchur shchur shchur left review comments

@prateekdesai04 prateekdesai04 prateekdesai04 left review comments

@suzhoum suzhoum suzhoum approved these changes

@zhiqiangdon zhiqiangdon Awaiting requested review from zhiqiangdon

Assignees
No one assigned
Labels
dependency Related to dependency packages priority: 0 Maximum priority
Projects
None yet
Milestone
1.1 Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Innixma @yinweisu @shchur @suzhoum @prateekdesai04