Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoMM] Update default in the conv-lora example #4025

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

zhiqiangdon
Copy link
Contributor

Issue #, if available:

Description of changes:
Update the default batch_size and per_gpu_batch_size to be consistent with the paper.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhiqiangdon zhiqiangdon added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Apr 2, 2024
Copy link
Collaborator

@Harry-zzh Harry-zzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinweisu
Copy link
Collaborator

yinweisu commented Apr 2, 2024

Previous CI Run Current CI Run
types-requests==2.31.0.20240311 types-requests==2.31.0.20240402
types-requests==2.31.0.20240311 types-requests==2.31.0.20240402

Copy link
Contributor

@prateekdesai04 prateekdesai04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhiqiangdon zhiqiangdon merged commit ff18c57 into autogluon:master Apr 2, 2024
16 checks passed
Copy link

github-actions bot commented Apr 2, 2024

Job PR-4025-79acbac is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4025/79acbac/index.html

prateekdesai04 pushed a commit to prateekdesai04/autogluon that referenced this pull request Apr 3, 2024
@zhiqiangdon zhiqiangdon deleted the conv-lora-example branch April 11, 2024 21:36
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants