[timeseries] Fix long path name issue on Windows for Chronos #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canerturkmen
added
bug
|
AnirudhDagar
approved these changes
Apr 6, 2024
|
/platform_tests ref=fix-chronos-win-path-issue |
This branch is on my fork. Will it still work? |
|
yes the branch being on fork (i'm not sure if it matters at all if one has the PAT setup, which for some reason didn't work for me) doesn't matter when initiated manually through actions: https://github.com/autogluon/autogluon/actions/runs/8579909126 (now passing for windows, except for 3.8 which should be fixed when we merge #4051) |
|
Job PR-4052-531072b is done. |
LennartPurucker
pushed a commit
to LennartPurucker/autogluon
that referenced
this pull request
Jun 1, 2024
…on#4052) Co-authored-by: Anirudh Dagar <anirudhdagar6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Previously, models saved to long local pathnames caused test failures due to Windows' MAX_PATH. Our path names are now safe for both Windows'
os.path.sepand also truncates the names of models loaded locally to increase readability and avoid MAX_PATH issues.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.